Temporary PR CI Check for test/addTestsandCIForNIOAsyncRuntime#11
Open
scottmarchant wants to merge 8 commits intomainfrom
Open
Temporary PR CI Check for test/addTestsandCIForNIOAsyncRuntime#11scottmarchant wants to merge 8 commits intomainfrom
scottmarchant wants to merge 8 commits intomainfrom
Conversation
798a61f to
b3a89e7
Compare
…3580) ### Motivation: A recent PR (apple#3574) added support for customising the container environment used for the matrix job for users of the reusable workflow. It supported a custom Dockerfile and controlling `--cap-add` options to the `docker run` command. Users who require this fine-grained control with `--cap-add` also will benefit from being able to control the `--security-opt` of the `docker run` command. ### Modifications: - Add support for `--security-opt` docker flags in custom CI jobs ### Result: Users of the reusable matrix CI workflow can control the `--security-opt` for the container.
Translate `HTTPHeaderValidationTests` to Swift testing ### Motivation: We want to add tests that use parameterized testing to `HTTPHeaderValidationTests`. In order to allow this we first need to translate this file to use Swift Testing instead of XCTest. ### Modifications: - Mechanical translation of `HTTPHeaderValidationTests` from XCTest to Swift testing. ### Result: We can add parameterized tests to HTTPHeaderValidationTests.
Add multi-version matrix support to Wasm Swift SDK workflow ### Motivation: The WASM CI only ran against nightly-main, making it impossible to distinguish toolchain regressions from code issues. Other repos in the ecosystem using `swiftlang/github-workflows` already test against `nightly-main`, `nightly-6.3`, and `6.3` by default. ### Modifications: - Add `nightly_main_enabled`, `nightly_6_3_enabled`, and `release_6_3_enabled` boolean inputs to `wasm_swift_sdk.yml` (all defaulting to `true`, matching the coverage of `swiftlang/github-workflows/swift_package_test.yml`) and update the matrix generation to emit the appropriate entry per enabled version. - Update `install_swift_sdk.sh` to support non-main branch snapshots by deriving the API and download paths from `INSTALL_SWIFT_BRANCH` rather than hardcoding `main`/`development`. - Fail early with a clear message if the branch snapshot API returns no results, rather than hitting an unbound variable error. ### Result: WASM builds are now tested against multiple Swift versions, providing a stable baseline to identify nightly-only regressions. Callers using the workflow without arguments get the new default coverage automatically; those who want to narrow the matrix can set specific version inputs to `false`. --------- Co-authored-by: Rick Newton-Rogers <rnro@apple.com> Co-authored-by: Cory Benfield <lukasa@apple.com>
…#3567) Split FoundationEssentials extensions from NIOFoundationCompat ### Motivation: Resolves apple#3038 ### Modifications: Split NIOFoundationCompat into two and only import FoundationEssentials and NIOFoundationEssentialsCompat where appropriate. ### Result: ByteBuffer/Codable extensions can be used without vendoring the code or linking to Foundation. Co-authored-by: Johannes Weiss <johannesweiss@apple.com> Co-authored-by: Fabian Fett <fabianfett@apple.com>
…ncRuntime is a new module that provides alternative implementations of MTELG and NIOThreadPool using Swift Concurrency. It compiles to wasm and runs in the browser. [Human-Directed AI Assistance]
b3a89e7 to
3f1a790
Compare
…me provides the same functionality as equivalent components in NIOPosix.
3f1a790 to
40f8598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary PR useful for running CI checks
Upstream PR: apple#3488